|
| From: | Richard Henderson |
| Subject: | Re: [PATCH] tcg: Reset free_temps before tcg_optimize |
| Date: | Sun, 8 Dec 2024 16:29:33 -0600 |
| User-agent: | Mozilla Thunderbird |
On 12/8/24 12:01, Philippe Mathieu-Daudé wrote:
On 7/12/24 22:47, Richard Henderson wrote:When allocating new temps during tcg_optmize, do not re-use any EBB temps that were used within the TB. We do not have any idea what span of the TB in which the temp was live. Cc: qemu-stable@nongnu.org Fixes: fb04ab7ddd8 ("tcg/optimize: Lower TCG_COND_TST{EQ,NE} if unsupported")Hmm, the problem is due to arg_new_temp()?
Yes.
Maybe add as tcg_temp_[ebb]_[reset|flush]() helper so we can reuse, like in tcg_func_start() and plugin_gen_inject()?
Ah, right. I had a memory of solving this same problem once, but couldn't remember where, or if it was on a branch somewhere. Good idea.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |