Re: [PATCH] target/i386: Use probe_access_full_mmu in ptw_translate

[Richard Henderson]

On 10/8/24 20:48, Philippe Mathieu-Daudé wrote:
> On 8/10/24 21:20, Richard Henderson wrote:
> > The probe_access_full_mmu function was designed for this purpose,
> > and does not report the memory operation event to plugins.
> >
> > Cc: qemu-stable@nongnu.org
> > Fixes: 6d03226b422 ("plugins: force slow path when plugins instrument memory 
> > ops")
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/i386/tcg/sysemu/excp_helper.c | 10 ++++------
> >   1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/target/i386/tcg/sysemu/excp_helper.c 
> > b/target/i386/tcg/sysemu/excp_helper.c
> > index 8fb05b1f53..8f4dc08535 100644
> > --- a/target/i386/tcg/sysemu/excp_helper.c
> > +++ b/target/i386/tcg/sysemu/excp_helper.c
> > @@ -62,12 +62,11 @@ typedef struct PTETranslate {
> >   static bool ptw_translate(PTETranslate *inout, hwaddr addr, uint64_t ra)
>
> We can remove the @ra argument; maybe clearer to do it in a
> separate commit.

Good idea.

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>