Re: [PATCH 1/2] meson: define qemu_isa_flags

[Richard Henderson]

On 10/7/24 07:48, Paolo Bonzini wrote:
> On Mon, Oct 7, 2024 at 4:46 PM Richard Henderson
> <richard.henderson@linaro.org> wrote:
> > > -  qemu_common_flags = ['-march=i486'] + qemu_common_flags
> > > +  qemu_isa_flags = ['-march=i486']
> >
> > Use += ?
>
> Here the qemu_isa_flags are known to be empty.

... until we add something else beforehand and fail to update.
Surely it's easier to assume that it's not empty.

> I just didn't want to change behavior here (especially since this
> patch was already about subtle changes in behavior). But you're right
> that at least within qemu_isa_flags the order should not matter.

Fair enough.


r~