[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled
From: |
Michael Tokarev |
Subject: |
Re: [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled |
Date: |
Mon, 16 Sep 2024 17:46:40 +0300 |
User-agent: |
Mozilla Thunderbird |
On 11.09.2024 12:14, gert.wollny@collabora.com wrote:
From: Gert Wollny <gert.wollny@collabora.com>
Before 176e3783f2ab (ui/sdl2: OpenGL window context)
SDL_CreateRenderer was called unconditionally setting
the swap interval to 0. Since SDL_CreateRenderer is now no
longer called when OpenGL is enabled, the swap interval is
no longer set explicitly and vsync handling depends on
the environment settings which may lead to a performance
regression with virgl as reported in
https://gitlab.com/qemu-project/qemu/-/issues/2565
Restore the old vsync handling by explicitly calling
SDL_GL_SetSwapInterval if OpenGL is enabled.
Fixes: 176e3783f2ab (ui/sdl2: OpenGL window context)
Closes: https://gitlab.com/qemu-project/qemu/-/issues/2565
Is it a qemu-stable material (8.2, 9.0, 9.1) ?
Picked it up for now, please notify me if I should drop it.
Also please notify me if I should pick some other changes
for -stable.
Thanks,
/mjt
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled,
Michael Tokarev <=