qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vnc: fix crash when no console attached


From: Akihiko Odaki
Subject: Re: [PATCH] vnc: fix crash when no console attached
Date: Thu, 22 Aug 2024 13:15:36 +0900
User-agent: Mozilla Thunderbird

On 2024/08/20 22:11, marcandre.lureau@redhat.com wrote:
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Since commit e99441a3793b5 ("ui/curses: Do not use console_select()")
qemu_text_console_put_keysym() no longer checks for NULL console
argument, which leads to a later crash:

Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault.
0x00005555559ee186 in qemu_text_console_handle_keysym (s=0x0, keysym=31) at 
../ui/console-vc.c:332
332             } else if (s->echo && (keysym == '\r' || keysym == '\n')) {
(gdb) bt
  #0  0x00005555559ee186 in qemu_text_console_handle_keysym (s=0x0, keysym=31) 
at ../ui/console-vc.c:332
  #1  0x00005555559e18e5 in qemu_text_console_put_keysym (s=<optimized out>, 
keysym=<optimized out>) at ../ui/console.c:303
  #2  0x00005555559f2e88 in do_key_event (vs=vs@entry=0x5555579045c0, 
down=down@entry=1, keycode=keycode@entry=60, sym=sym@entry=65471) at 
../ui/vnc.c:2034
  #3  0x00005555559f845c in ext_key_event (vs=0x5555579045c0, down=1, sym=65471, 
keycode=<optimized out>) at ../ui/vnc.c:2070
  #4  protocol_client_msg (vs=0x5555579045c0, data=<optimized out>, len=<optimized 
out>) at ../ui/vnc.c:2514
  #5  0x00005555559f515c in vnc_client_read (vs=0x5555579045c0) at 
../ui/vnc.c:1607

Fixes: e99441a3793b5 ("ui/curses: Do not use console_select()")
Fixes: https://issues.redhat.com/browse/RHEL-50529
Cc: qemu-stable@nongnu.org
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]