Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

[Philippe Mathieu-Daudé]

Hi Michael,

On 11/8/24 19:43, Michael Tokarev wrote:
> 03.05.2024 15:34, Philippe Mathieu-Daudé wrote:
> > In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out")
> > we unfortunately restricted the tcg_flush_jmp_cache() to system
> > emulation. Move it to the common tcg_exec_cpu_reset_hold() handler
> > so user emulation gets the jmp_cache initialized when threads
> > are created.
> >
> > Remove the NULL check in tcg_flush_jmp_cache() from commit 4e4fa6c12d
> > ("accel/tcg: Complete cpu initialization before registration") which
> > was a band-aid fix for incorrect commit bb6cf6f016.
> >
> > Cc: qemu-stable@nongnu.org
> > Fixes: bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out")
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Hi!
>
> Has this change been forgotten, or is it not appropriate anymore?

Not forgotten and still need to be fixed, however unfortunately
this exposed a bug in user-mode SYS_exit_group when using plugins
(see qemu_plugin_disable_mem_helpers call in qemu_plugin_user_exit).

Pierrick is working on it, and I'll rebase this series once his
work gets merged. Next release :/

Regards,

Phil.