[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] net: Fix '-net nic,model=' for non-help arguments
From: |
David Woodhouse |
Subject: |
[PATCH] net: Fix '-net nic,model=' for non-help arguments |
Date: |
Tue, 06 Aug 2024 18:21:37 +0100 |
User-agent: |
Evolution 3.44.4-0ubuntu2 |
From: David Woodhouse <dwmw@amazon.co.uk>
Oops, don't *delete* the model option when checking for 'help'.
Fixes: 64f75f57f9d2 ("net: Reinstate '-net nic, model=help' output as
documented in man page")
Reported-by: Hans <sungdgdhtryrt@gmail.com>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Cc: qemu-stable@nongnu.org
---
This whole mess of alternative command line options could really do
with some self tests. And maybe removing half of them. Three ways of
doing the same thing ought to suffice.
net/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index 2eb8bc9c0b..fc1125111c 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1737,7 +1737,7 @@ void net_check_clients(void)
static int net_init_client(void *dummy, QemuOpts *opts, Error **errp)
{
- const char *model = qemu_opt_get_del(opts, "model");
+ const char *model = qemu_opt_get(opts, "model");
if (is_nic_model_help_option(model)) {
return 0;
--
2.44.0
smime.p7s
Description: S/MIME cryptographic signature
- [PATCH] net: Fix '-net nic,model=' for non-help arguments,
David Woodhouse <=