[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] stdvga: fix screen blanking
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [PATCH v2 1/3] stdvga: fix screen blanking |
|
Date: |
Wed, 5 Jun 2024 16:08:33 +0400 |
Hi
On Wed, Jun 5, 2024 at 11:36 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Tue, Jun 04, 2024 at 10:27:18AM GMT, Marc-André Lureau wrote:
> > Hi
> >
> > > + if (is_buffer_shared(surface)) {
> >
> > Perhaps the suggestion to rename the function (in the following patch)
> > should instead be surface_is_allocated() ? that would match the actual
> > flag check. But callers would have to ! the result. Wdyt?
>
> surface_is_shadow() ? Comes closer to the typical naming in computer
> graphics.
If the underlying flag is renamed too, that's ok to me.