RE: [PULL 00/11] Ui patches

[Kim, Dongwon]

Hi Marc-André,

> -----Original Message-----
> From: Marc-André Lureau <marcandre.lureau@gmail.com>
> Sent: Wednesday, May 15, 2024 3:44 AM
> To: Michael Tokarev <mjt@tls.msk.ru>
> Cc: qemu-devel@nongnu.org; qemu-stable <qemu-stable@nongnu.org>;
> hikalium <hikalium@hikalium.com>; Kim, Dongwon <dongwon.kim@intel.com>
> Subject: Re: [PULL 00/11] Ui patches
> 
> Hi
> 
> On Wed, May 15, 2024 at 2:29 PM Michael Tokarev <mjt@tls.msk.ru> wrote:
> >
> > 14.05.2024 16:17, marcandre.lureau@redhat.com wrote:
> > > ----------------------------------------------------------------
> > > UI: small fixes and improvements
> > >
> > > ----------------------------------------------------------------
> > >
> > > Bernhard Beschow (1):
> > >    ui/sdl2: Allow host to power down screen
> > >
> > > Dongwon Kim (7):
> > >    ui/gtk: Draw guest frame at refresh cycle
> > >    ui/gtk: Check if fence_fd is equal to or greater than 0
> > >    ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and
> > >      helpers
> > >    ui/console: Use qemu_dmabuf_get_..() helpers instead
> > >    ui/console: Use qemu_dmabuf_set_..() helpers instead
> > >    ui/console: Use qemu_dmabuf_new() and free() helpers instead
> > >    ui/console: move QemuDmaBuf struct def to dmabuf.c
> > >
> > > Sergii Zasenko (1):
> > >    Allow UNIX socket option for VNC websocket
> > >
> > > hikalium (2):
> > >    ui/gtk: Add gd_motion_event trace event
> > >    ui/gtk: Fix mouse/motion event scaling issue with GTK display
> > > backend
> >
> >  From this list, it looks like
> >
> >    ui/gtk: Draw guest frame at refresh cycle
> 
> I would allow a bit more time for this to be actually more widely tested.
> 
> Dongwon, wdyt?
[Kim, Dongwon] Ok, that sounds good to me.

> 
> >    ui/gtk: Check if fence_fd is equal to or greater than 0
> > (questionable, minor issue)
> 
> minor, but fine in stable too.
> 
> >    ui/gtk: Fix mouse/motion event scaling issue with GTK display
> > backend
> 
> ok for stable imho (even though I don't like that we don't support hidpi
> correctly, as I described in the patch review)