[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Stable-8.1.2 59/61] util/log: re-allow switching away from stderr log f
From: |
Michael Tokarev |
Subject: |
[Stable-8.1.2 59/61] util/log: re-allow switching away from stderr log file |
Date: |
Thu, 12 Oct 2023 10:16:15 +0300 |
From: Fiona Ebner <f.ebner@proxmox.com>
Commit 59bde21374 ("util/log: do not close and reopen log files when
flags are turned off") prevented switching away from stderr on a
subsequent invocation of qemu_set_log_internal(). This prevented
switching away from stderr with the 'logfile' monitor command as well
as an invocation like
> ./qemu-system-x86_64 -trace 'qemu_mutex_lock,file=log'
from opening the specified log file.
Fixes: 59bde21374 ("util/log: do not close and reopen log files when flags are
turned off")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20231004124446.491481-1-f.ebner@proxmox.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit f05142d511e86d8e97967d21f205d990dfc634de)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/util/log.c b/util/log.c
index def88a9402..d36c98da0b 100644
--- a/util/log.c
+++ b/util/log.c
@@ -298,6 +298,8 @@ static bool qemu_set_log_internal(const char *filename,
bool changed_name,
r->fd = logfile;
qatomic_rcu_set(&global_file, NULL);
call_rcu(r, rcu_close_file, rcu);
+ }
+ if (changed_name) {
logfile = NULL;
}
}
--
2.39.2
- [Stable-8.1.2 00/61] Patch Round-up for stable 8.1.2, freeze on 2023-12-14, Michael Tokarev, 2023/10/12
- [Stable-8.1.2 58/61] vfio/display: Fix missing update to set backing fields, Michael Tokarev, 2023/10/12
- [Stable-8.1.2 60/61] migration/qmp: Fix crash on setting tls-authz with null, Michael Tokarev, 2023/10/12
- [Stable-8.1.2 59/61] util/log: re-allow switching away from stderr log file,
Michael Tokarev <=
- [Stable-8.1.2 61/61] hw/audio/es1370: reset current sample counter, Michael Tokarev, 2023/10/12
- Re: [Stable-8.1.2 00/61] Patch Round-up for stable 8.1.2, freeze on 2023-10-14, Michael Tokarev, 2023/10/12