Re: [PATCH v2 0/3] block: align CoR requests to subclusters

[Denis V. Lunev]

On 9/7/23 22:11, Michael Tokarev wrote:
> 11.07.2023 20:25, Andrey Drobyshev via wrote:
> > v1 --> v2:
> >   * Fixed line indentation;
> >   * Fixed wording in a comment;
> >   * Added R-b.
> >
> > v1: 
> > https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html
> >
> > Andrey Drobyshev (3):
> >    block: add subcluster_size field to BlockDriverInfo
> >    block/io: align requests to subcluster_size
> >    tests/qemu-iotests/197: add testcase for CoR with subclusters
> >
> >   block.c                      |  7 +++++
> >   block/io.c                   | 50 ++++++++++++++++++------------------
> >   block/mirror.c               |  8 +++---
> >   block/qcow2.c                |  1 +
> >   include/block/block-common.h |  5 ++++
> >   include/block/block-io.h     |  8 +++---
> >   tests/qemu-iotests/197       | 29 +++++++++++++++++++++
> >   tests/qemu-iotests/197.out   | 24 +++++++++++++++++
> >   8 files changed, 99 insertions(+), 33 deletions(-)
>
> So, given the size of patch series and amount of time the series
> were sitting there.. I'm hesitating to apply it to -stable.
> The whole issue, while real, smells like somewhat unusual case.
>
> Any comments on this?
>
> Thanks,
>
> /mjt

The issue was observed by us in the reality on not yet
released product, but the series requires correct, which
has been sent as 4/3 patch today by Andrey. Unit tests
are broken at the moment.

Thanks,
    Den