[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] qemu-nbd: pass structure into nbd_client_thread instead
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/5] qemu-nbd: pass structure into nbd_client_thread instead of plain char* |
Date: |
Mon, 17 Jul 2023 13:56:04 -0500 |
User-agent: |
NeoMutt/20230517 |
On Mon, Jul 17, 2023 at 04:55:40PM +0200, Denis V. Lunev wrote:
> We are going to pass additional flag inside next patch.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> CC: <qemu-stable@nongnu.org>
> ---
> qemu-nbd.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
We could also have just promoted any additional variables to be shared
between the parent and child from stack-local in main() to global; but
this refactoring seems cleaner.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org