|
From: | Juan Quintela |
Subject: | Re: [PATCH] migration: Fix migration crash when target psize larger than host |
Date: | Mon, 30 Jan 2023 05:38:35 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Peter Xu <peterx@redhat.com> wrote: > Commit d9e474ea56 overlooked the case where the target psize is even larger > than the host psize. One example is Alpha has 8K page size and migration > will start to crash the source QEMU when running Alpha migration on x86. > > Fix it by detecting that case and set host start/end just to cover the > single page to be migrated. > > This will slightly optimize the common case where host psize equals to > guest psize so we don't even need to do the roundups, but that's trivial. > > Cc: qemu-stable@nongnu.org > Reported-by: Thomas Huth <thuth@redhat.com> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1456 > Fixes: d9e474ea56 ("migration: Teach PSS about host page") > Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> queued
[Prev in Thread] | Current Thread | [Next in Thread] |