Re: [PATCH] acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block

[Philippe Mathieu-Daudé]

On 4/1/23 11:38, Igor Mammedov wrote:
> On Wed, 4 Jan 2023 10:34:09 +0100
> Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> > On 4/1/23 10:01, Laszlo Ersek wrote:
> [...]
> > > diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c
> > > index 53654f863830..ff14c3f4106f 100644
> > > --- a/hw/acpi/cpu_hotplug.c
> > > +++ b/hw/acpi/cpu_hotplug.c
> > > @@ -52,6 +52,9 @@ static const MemoryRegionOps AcpiCpuHotplug_ops = {
> > >        .endianness = DEVICE_LITTLE_ENDIAN,
> > >        .valid = {
> > >            .min_access_size = 1,
> > > +        .max_access_size = 4,
> > > +    },
> > > +    .impl = {
> > >            .max_access_size = 1,
> >
> > Arguably:
> > Fixes: b8622725cf ("acpi_piix4: Add infrastructure to send CPU hot-plug
> > GPE to guest")
>
> nope, this one is correct, as legacy interface used 1 byte access only

Yes, Laszlo explained elsewhere in the thread.