[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] vdpa: Fix SIGSEGV on failed vdpa devices
From: |
Jason Wang |
Subject: |
Re: [PATCH 0/3] vdpa: Fix SIGSEGV on failed vdpa devices |
Date: |
Mon, 22 Nov 2021 11:56:27 +0800 |
On Fri, Nov 19, 2021 at 6:20 PM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> Qemu falls back on userland handlers even if vhost-user and vhost-vdpa
> cases. These assumes a tap device can handle the packets.
>
> If a vdpa device fail to start, it can trigger a sigsegv because of
> that. Add dummy receivers that return no progress so it can keep
> running.
>
> Tested with a modified version of vp_vdpa to fail negotiation.
>
> This is another bersion of the patch proposed in [1], but the subject
> didn't match the patch anymore.
>
> [1] https://lists.nongnu.org/archive/html/qemu-devel/2021-11/msg03719.html
>
As discussed, we need to consider fixing the gRARP transmission issue
on top, any idea on that?
Thanks
> Eugenio Pérez (3):
> virtio-net: Fix indentation
> vdpa: Add dummy receive callbacks
> virtio-net: Fix log message
>
> hw/net/virtio-net.c | 13 +++++++------
> net/vhost-vdpa.c | 16 ++++++++++++++++
> 2 files changed, 23 insertions(+), 6 deletions(-)
>
> --
> 2.27.0
>
>