[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 31/53] KVM: x86: believe what KVM says about WAITPKG
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PULL 31/53] KVM: x86: believe what KVM says about WAITPKG |
|
Date: |
Tue, 7 Jul 2020 13:58:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 07/07/20 13:42, Maxim Levitsky wrote:
>> +bool kvm_has_waitpkg(void)
>> +{
>> + return has_msr_umwait;
> Note that this depends on the fix in the kernel
> to report this msr only when UMWAIT is supported.
> I personally don't mind that.
>
> If we want to support older kernels that don't,
> then we have to run 'cpuid' ourselves and check the result.
>
> Otherwise looks good to me.
Yes, the original kernel version was completely busted but fortunately
the fix will make it into stable kernels, probably faster than it can
make into QEMU releases...
Paolo