[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/22] net/virtio: Fix failover_replug_primary() return value
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 01/22] net/virtio: Fix failover_replug_primary() return value regression |
|
Date: |
Wed, 24 Jun 2020 18:47:46 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Mon, Jun 22, 2020 at 11:25:59PM +0200, Jens Freimann wrote:
>> On Mon, Jun 22, 2020 at 12:42:29PM +0200, Markus Armbruster wrote:
>> > Commit 150ab54aa6 "net/virtio: fix re-plugging of primary device"
>> > fixed failover_replug_primary() to return false on failure. Commit
>> > 5a0948d36c "net/virtio: Fix failover error handling crash bugs" broke
>> > it again for hotplug_handler_plug() failure. Unbreak it.
>> >
>> > Commit 5a0948d36c4cbc1c5534afac6fee99de55245d12
>> >
>> > Fixes: 5a0948d36c4cbc1c5534afac6fee99de55245d12
>> > Cc: Jens Freimann <jfreimann@redhat.com>
>> > Cc: Michael S. Tsirkin <mst@redhat.com>
>> > Cc: qemu-stable@nongnu.org
>> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> > ---
>> > hw/net/virtio-net.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>>
>> Reviewed-by: Jens Freimann <jfreimann@redhat.com>
>>
>> Thanks!
>>
>> regards,
>> Jens
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Who's merging this? Jason? Or is all this going through a single tree?
I'm happy to take care of the pull request for the whole series.
Simpler for me, actually.