[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/3] virtio-balloon: fix free page hinting check on unrealize
From: |
David Hildenbrand |
Subject: |
[PATCH v2 2/3] virtio-balloon: fix free page hinting check on unrealize |
Date: |
Wed, 20 May 2020 12:04:38 +0200 |
Checking against guest features is wrong. We allocated data structures
based on host features. We can rely on "free_page_bh" as an indicator
whether to un-do stuff instead.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alexander Duyck <address@hidden>
Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Cc: address@hidden
Cc: Wei Wang <address@hidden>
Cc: Michael S. Tsirkin <address@hidden>
Cc: Philippe Mathieu-Daudé <address@hidden>
Cc: Alexander Duyck <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/virtio/virtio-balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 7ff6a7aa7c..32e9fe3f64 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -818,7 +818,7 @@ static void virtio_balloon_device_unrealize(DeviceState
*dev)
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
VirtIOBalloon *s = VIRTIO_BALLOON(dev);
- if (virtio_balloon_free_page_support(s)) {
+ if (s->free_page_bh) {
qemu_bh_delete(s->free_page_bh);
virtio_balloon_free_page_stop(s);
precopy_remove_notifier(&s->free_page_report_notify);
--
2.25.4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH v2 2/3] virtio-balloon: fix free page hinting check on unrealize,
David Hildenbrand <=