[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] qcow2: Fix alloc_cluster_abort() for pre-existing cluste
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 0/3] qcow2: Fix alloc_cluster_abort() for pre-existing clusters |
Date: |
Wed, 26 Feb 2020 14:53:36 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 25.02.2020 um 15:31 hat Max Reitz geschrieben:
> With c3b6658c1a5a3fb2, Kevin has fixed a case in alloc_cluster_abort()
> where we used to free a cluster that wasn’t even allocated by
> handle_alloc(), thus leading to an error and/or corruption. Besides
> external data files, there is another case where alloc_cluster_abort()
> must not free the “new” cluster: Namely when the cluster isn’t new
> because we’re reusing an existing pre-allocated zero cluster.
>
> I think Berto’s subcluster series fixes this, too, but it’s still an
> RFC, so I suppose we have to fix the bug independently of it.
>
> Patch 2 adds a regression test; patch 3 adds a regression test for
> Kevin’s patch c3b6658c1a5a3fb2 (which didn’t come with one).
Thanks, applied to the block branch.
Kevin