[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-block] [PATCH v2 1/7] curl: Keep pointer to the
From: |
Maxim Levitsky |
Subject: |
Re: [Qemu-stable] [Qemu-block] [PATCH v2 1/7] curl: Keep pointer to the CURLState in CURLSocket |
Date: |
Tue, 10 Sep 2019 19:11:17 +0300 |
On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote:
> A follow-up patch will make curl_multi_do() and curl_multi_read() take a
> CURLSocket instead of the CURLState. They still need the latter,
> though, so add a pointer to it to the former.
>
> Cc: address@hidden
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> ---
> block/curl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/block/curl.c b/block/curl.c
> index d4c8e94f3e..92dc2f630e 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -80,6 +80,7 @@ static CURLMcode __curl_multi_socket_action(CURLM
> *multi_handle,
> #define CURL_BLOCK_OPT_TIMEOUT_DEFAULT 5
>
> struct BDRVCURLState;
> +struct CURLState;
>
> static bool libcurl_initialized;
>
> @@ -97,6 +98,7 @@ typedef struct CURLAIOCB {
>
> typedef struct CURLSocket {
> int fd;
> + struct CURLState *state;
> QLIST_ENTRY(CURLSocket) next;
> } CURLSocket;
>
> @@ -180,6 +182,7 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int
> action,
> if (!socket) {
> socket = g_new0(CURLSocket, 1);
> socket->fd = fd;
> + socket->state = state;
> QLIST_INSERT_HEAD(&state->sockets, socket, next);
> }
> socket = NULL;
Reviewed-by: Maxim Levitsky <address@hidden>
Best regards,
Maxim Levitsky
- [Qemu-stable] [PATCH v2 0/7] block/curl: Fix hang and potential crash, Max Reitz, 2019/09/10
- [Qemu-stable] [PATCH v2 1/7] curl: Keep pointer to the CURLState in CURLSocket, Max Reitz, 2019/09/10
- Re: [Qemu-stable] [Qemu-block] [PATCH v2 1/7] curl: Keep pointer to the CURLState in CURLSocket,
Maxim Levitsky <=
- [Qemu-stable] [PATCH v2 2/7] curl: Keep *socket until the end of curl_sock_cb(), Max Reitz, 2019/09/10
- [Qemu-stable] [PATCH v2 3/7] curl: Check completion in curl_multi_do(), Max Reitz, 2019/09/10
- [Qemu-stable] [PATCH v2 4/7] curl: Pass CURLSocket to curl_multi_do(), Max Reitz, 2019/09/10
- [Qemu-stable] [PATCH v2 5/7] curl: Report only ready sockets, Max Reitz, 2019/09/10