[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-stable] [PULL v2 7/7] block/backup: disable copy_range for compres
From: |
Max Reitz |
Subject: |
[Qemu-stable] [PULL v2 7/7] block/backup: disable copy_range for compressed backup |
Date: |
Tue, 6 Aug 2019 13:59:52 +0200 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
Enabled by default copy_range ignores compress option. It's definitely
unexpected for user.
It's broken since introduction of copy_range usage in backup in
9ded4a011496.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-id: address@hidden
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Cc: address@hidden
Signed-off-by: Max Reitz <address@hidden>
---
block/backup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/backup.c b/block/backup.c
index 1ee271f9f1..b26c22c4b8 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -657,7 +657,7 @@ BlockJob *backup_job_create(const char *job_id,
BlockDriverState *bs,
job->cluster_size = cluster_size;
job->copy_bitmap = copy_bitmap;
copy_bitmap = NULL;
- job->use_copy_range = true;
+ job->use_copy_range = !compress; /* compression isn't supported for it */
job->copy_range_size = MIN_NON_ZERO(blk_get_max_transfer(job->common.blk),
blk_get_max_transfer(job->target));
job->copy_range_size = MAX(job->cluster_size,
--
2.21.0
- [Qemu-stable] [PULL v2 0/7] Block patches for 4.1.0-rc4, Max Reitz, 2019/08/06
- [Qemu-stable] [PULL v2 1/7] backup: Copy only dirty areas, Max Reitz, 2019/08/06
- [Qemu-stable] [PULL v2 2/7] iotests: Test backup job with two guest writes, Max Reitz, 2019/08/06
- [Qemu-stable] [PULL v2 3/7] util/hbitmap: update orig_size on truncate, Max Reitz, 2019/08/06
- [Qemu-stable] [PULL v2 5/7] mirror: Only mirror granularity-aligned chunks, Max Reitz, 2019/08/06
- [Qemu-stable] [PULL v2 4/7] iotests: Test incremental backup after truncation, Max Reitz, 2019/08/06
- [Qemu-stable] [PULL v2 7/7] block/backup: disable copy_range for compressed backup,
Max Reitz <=
- [Qemu-stable] [PULL v2 6/7] iotests: Test unaligned blocking mirror write, Max Reitz, 2019/08/06
- Re: [Qemu-stable] [PULL v2 0/7] Block patches for 4.1.0-rc4, Peter Maydell, 2019/08/06