[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-stable] [PATCH-for-4.1 v4 7/7] virtio-balloon: No need to track su
From: |
David Hildenbrand |
Subject: |
[Qemu-stable] [PATCH-for-4.1 v4 7/7] virtio-balloon: No need to track subpages for the PBP anymore |
Date: |
Thu, 25 Jul 2019 13:36:38 +0200 |
As ramblocks cannot get removed/readded while we are processing a bulk
of inflation requests, there is no more need to track the page size
in form of the number of subpages.
Suggested-by: David Gibson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/virtio/virtio-balloon.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index a6282d58d4..fe9664e42c 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -36,7 +36,6 @@
typedef struct PartiallyBalloonedPage {
ram_addr_t base_gpa;
- long subpages;
unsigned long *bitmap;
} PartiallyBalloonedPage;
@@ -55,16 +54,15 @@ static PartiallyBalloonedPage
*virtio_balloon_pbp_alloc(ram_addr_t base_gpa,
PartiallyBalloonedPage *pbp = g_new0(PartiallyBalloonedPage, 1);
pbp->base_gpa = base_gpa;
- pbp->subpages = subpages;
pbp->bitmap = bitmap_new(subpages);
return pbp;
}
static bool virtio_balloon_pbp_matches(PartiallyBalloonedPage *pbp,
- ram_addr_t base_gpa, long subpages)
+ ram_addr_t base_gpa)
{
- return pbp->subpages == subpages && pbp->base_gpa == base_gpa;
+ return pbp->base_gpa == base_gpa;
}
static void balloon_inflate_page(VirtIOBalloon *balloon,
@@ -106,7 +104,7 @@ static void balloon_inflate_page(VirtIOBalloon *balloon,
base_gpa = memory_region_get_ram_addr(mr) + mr_offset -
(rb_offset - rb_aligned_offset);
- if (*pbp && !virtio_balloon_pbp_matches(*pbp, base_gpa, subpages)) {
+ if (*pbp && !virtio_balloon_pbp_matches(*pbp, base_gpa)) {
/* We've partially ballooned part of a host page, but now
* we're trying to balloon part of a different one. Too hard,
* give up on the old partial page */
--
2.21.0
- [Qemu-stable] [PATCH-for-4.1 v4 0/7] virtio-balloon: fixes, David Hildenbrand, 2019/07/25
- [Qemu-stable] [PATCH-for-4.1 v4 1/7] virtio-balloon: Fix wrong sign extension of PFNs, David Hildenbrand, 2019/07/25
- [Qemu-stable] [PATCH-for-4.1 v4 2/7] virtio-balloon: Fix QEMU crashes on pagesize > BALLOON_PAGE_SIZE, David Hildenbrand, 2019/07/25
- [Qemu-stable] [PATCH-for-4.1 v4 3/7] virtio-balloon: Simplify deflate with pbp, David Hildenbrand, 2019/07/25
- [Qemu-stable] [PATCH-for-4.1 v4 4/7] virtio-balloon: Better names for offset variables in inflate/deflate code, David Hildenbrand, 2019/07/25
- [Qemu-stable] [PATCH-for-4.1 v4 5/7] virtio-balloon: Rework pbp tracking data, David Hildenbrand, 2019/07/25
- [Qemu-stable] [PATCH-for-4.1 v4 7/7] virtio-balloon: No need to track subpages for the PBP anymore,
David Hildenbrand <=
- [Qemu-stable] [PATCH-for-4.1 v4 6/7] virtio-balloon: Use temporary PBP only, David Hildenbrand, 2019/07/25