Re: [Qemu-stable] [PATCH v2 4/4] iotests: add iotest 250 for testing blockdev-backup across iothread contexts

[John Snow]

On 5/17/19 7:18 AM, Max Reitz wrote:
> On 10.05.19 21:03, John Snow wrote:
>> Signed-off-by: John Snow <address@hidden>
>> ---
>>  tests/qemu-iotests/250     | 129 +++++++++++++++++++++++++++++++++++++
>>  tests/qemu-iotests/250.out | 119 ++++++++++++++++++++++++++++++++++
>>  tests/qemu-iotests/group   |   1 +
>>  3 files changed, 249 insertions(+)
>>  create mode 100755 tests/qemu-iotests/250
>>  create mode 100644 tests/qemu-iotests/250.out
>>
>> diff --git a/tests/qemu-iotests/250 b/tests/qemu-iotests/250
>> new file mode 100755
>> index 0000000000..1406b10958
>> --- /dev/null
>> +++ b/tests/qemu-iotests/250
>> @@ -0,0 +1,129 @@
> 
> [...]
> 
>> +    def create_target(filepath, name, size):
>> +        basename = os.path.basename(filepath)
>> +        nodename = "file_{}".format(basename)
>> +        log(vm.command('blockdev-create', job_id='job1',
>> +                       options={
>> +                           'driver': 'file',
>> +                           'filename': filepath,
>> +                           'size': size,
> 
> I think this should be 0.  No complaints apart from that, so I can fix
> that up when applying, if you agree.
> 
> Max
> 

Oh, should it? I guess you're right. At the very least, it's not right
to use the raw logical size here.

Yes, please feel free to amend this.

Thank you, Max!

>> +                       }))
>> +        vm.run_job('job1')
>> +        log(vm.command('blockdev-add', driver='file',
>> +                       node_name=nodename, filename=filepath))
>> +        log(vm.command('blockdev-create', job_id='job2',
>> +                       options={
>> +                           'driver': iotests.imgfmt,
>> +                           'file': nodename,
>> +                           'size': size,
>> +                       }))
>> +        vm.run_job('job2')
>> +        log(vm.command('blockdev-add', driver=iotests.imgfmt,
>> +                       node_name=name,
>> +                       file=nodename))
>> +
>