[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... fo
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash |
|
Date: |
Fri, 5 Apr 2019 17:11:59 +0100 |
|
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Kevin Wolf (address@hidden) wrote:
> Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben:
> > drive_new() returns null without setting an error when it provided
> > help. add_init_drive() assumes null means failure, and crashes trying
> > to report a null error.
> >
> > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25
> > Cc: address@hidden
> > Signed-off-by: Markus Armbruster <address@hidden>
>
> We should probably have a test case for this.
Perhaps just adding:
drive_add 0 format=help
to the hmp_cmds list in tests/test-hmp.c ?
Dave
> Kevin
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK