[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] qemu-img: fix error reporting for -object
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-stable] [PATCH] qemu-img: fix error reporting for -object |
Date: |
Wed, 20 Feb 2019 12:59:47 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 19.02.2019 um 12:46 hat Daniel P. Berrangé geschrieben:
> Error reporting for user_creatable_add_opts_foreach was changed so that
> it no longer called 'error_report_err' in:
>
> commit 7e1e0c11127bde81cff260fc6859690435c509d6
> Author: Markus Armbruster <address@hidden>
> Date: Wed Oct 17 10:26:43 2018 +0200
>
> qom: Clean up error reporting in user_creatable_add_opts_foreach()
>
> Some callers were updated to pass in "&error_fatal" but all the ones in
> qemu-img were left passing NULL. As a result all errors went to
> /dev/null instead of being reported to the user.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
Thanks, applied to the block branch.
Kevin