[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v4 9/9] intel-iommu: rework the page walk logic
From: |
Peter Xu |
Subject: |
Re: [Qemu-stable] [PATCH v4 9/9] intel-iommu: rework the page walk logic |
Date: |
Thu, 24 May 2018 10:54:19 +0800 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Wed, May 23, 2018 at 05:33:34PM +0300, Michael S. Tsirkin wrote:
> On Fri, May 18, 2018 at 03:25:17PM +0800, Peter Xu wrote:
> > SECURITY IMPLICATION: this patch will fix a potential small window that
> > the DMA page table might be incomplete or invalid when the guest sends
> > domain/context invalidations to a device. It can cause random DMA
> > errors for assigned devices.
>
> So this is more a correctness IMO. I don't see how can
> e.g. an application within guest cause any mischief
> with this, it will just get a non working device.
Yes, you are right. It causes valid mappings missing so there's no
risk to anyone but only unfunction. I should remove the "SECURITY
IMPLICATION" wordings.
Thanks,
--
Peter Xu
- [Qemu-stable] [PATCH v4 1/9] intel-iommu: send PSI always even if across PDEs, (continued)
- [Qemu-stable] [PATCH v4 1/9] intel-iommu: send PSI always even if across PDEs, Peter Xu, 2018/05/18
- [Qemu-stable] [PATCH v4 2/9] intel-iommu: remove IntelIOMMUNotifierNode, Peter Xu, 2018/05/18
- [Qemu-stable] [PATCH v4 3/9] intel-iommu: add iommu lock, Peter Xu, 2018/05/18
- [Qemu-stable] [PATCH v4 4/9] intel-iommu: only do page walk for MAP notifiers, Peter Xu, 2018/05/18
- [Qemu-stable] [PATCH v4 5/9] intel-iommu: introduce vtd_page_walk_info, Peter Xu, 2018/05/18
- [Qemu-stable] [PATCH v4 6/9] intel-iommu: pass in address space when page walk, Peter Xu, 2018/05/18
- [Qemu-stable] [PATCH v4 7/9] intel-iommu: trace domain id during page walk, Peter Xu, 2018/05/18
- [Qemu-stable] [PATCH v4 8/9] util: implement simple iova tree, Peter Xu, 2018/05/18
- [Qemu-stable] [PATCH v4 9/9] intel-iommu: rework the page walk logic, Peter Xu, 2018/05/18