Re: [Qemu-stable] [Qemu-devel] [PATCH] sparc: fix leon3 casa instruction when MMU is disabled

[KONRAD Frederic]

On 03/02/2018 08:04 PM, Richard Henderson wrote:
> On 03/02/2018 01:59 AM, KONRAD Frederic wrote:
> > From: KONRAD Frederic <address@hidden>
> >
> > Since the commit af7a06bac7d3abb2da48ef3277d2a415772d2ae8:
> > `casa [..](10), .., ..` (and probably others alternate space instructions)
> > triggers a data access exception when the MMU is disabled.
> >
> > When we enter get_asi(...) dc->mem_idx is set to MMU_PHYS_IDX when the MMU
> > is disabled. Just keep mem_idx unchanged in this case so we passthrough the
> > MMU when it is disabled.
> >
> > Signed-off-by: KONRAD Frederic <address@hidden>
> > ---
> >
> > Notes:
> >      Changes RFC -> V1:
> >       * emit the instruction with MMU_PHYS_IDX instead of checking that the MMU
> >         is enabled in get_physical_address(..)
> >
> >   target/sparc/translate.c | 5 +++++
> >   1 file changed, 5 insertions(+)
>
> Reviewed-by: Richard Henderson <address@hidden>
>
> r~

Thanks for the review Richard.

BTW I think it makes sense to have it in stable release..
So CC'ing qemu-stable.

Regards,
Fred