Re: [Qemu-stable] [Qemu-devel] [PATCH] linux-user/signal.c: Rename MC_* defines

[Peter Maydell]

On 30 January 2018 at 13:17, Peter Maydell <address@hidden> wrote:
> The SPARC code in linux-user/signal.c defines a set of
> MC_* constants. On some SPARC hosts these are also defined
> by sys/ucontext.h, resulting in build failures:
>
> linux-user/signal.c:2786:0: error: "MC_NGREG" redefined [-Werror]
>  #define MC_NGREG 19
>
> In file included from /usr/include/signal.h:302:0,
>                  from include/qemu/osdep.h:86,
>                  from linux-user/signal.c:19:
> /usr/include/sparc64-linux-gnu/sys/ucontext.h:59:0: note: this is the 
> location of the previous definition
>  # define MC_NGREG __MC_NGREG
>
> Rename all these constants to SPARC_MC_* to avoid the clash.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This has just started causing failures on the SPARC build
> box I use for merge tests (presumably due to a system
> header update), so I'm planning to apply this to master as
> a buildfix.

Now applied, thanks. I threw in a cc of qemu-stable too,
since otherwise stable point releases won't build on these hosts.

-- PMM