[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH for 2.11 0/2] QEMU crashes with CD device witho
From: |
Denis V. Lunev |
Subject: |
Re: [Qemu-stable] [PATCH for 2.11 0/2] QEMU crashes with CD device without media |
Date: |
Tue, 28 Nov 2017 19:29:20 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/28/2017 07:08 PM, Kevin Wolf wrote:
> Am 28.11.2017 um 13:10 hat Denis V. Lunev geschrieben:
>> There are 2 cases I have spotted so far:
>> 1) IDE ATAPI read processing. Actually this was reported from field
>> 2) QEMU IO hmp command (found during evaluation of (1))
>>
>> SCSI code checks during access that blk_is_available(). These patches add
>> same checks on different code paths.
>>
>> Pls decide whether these patches should go through sub-system trees or via
>> block tree.
> Why does this always come up in the last minute? :-(
>
> The real fix shouldn't be in the devices, but blk_aio_*() needs to
> handle empty drives gracefully. We already made a similar fix before the
> last release in commit 4da97120d, and I already didn't like it back
> then.
>
> Of course, we should have used the time to fix this properly, but as you
> can see, nothing has happened and we're running out of time again.
>
> Kevin
I see.
We have started ABRT report collection program a week ago. This
is the first result for QEMU from the real customer running
his own workload :(
What else can I say?
Den