[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-block] [PATCH 2/7] curl: never invoke callbacks
From: |
Max Reitz |
Subject: |
Re: [Qemu-stable] [Qemu-block] [PATCH 2/7] curl: never invoke callbacks with s->mutex held |
Date: |
Wed, 10 May 2017 18:33:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 10.05.2017 16:32, Paolo Bonzini wrote:
> All curl callbacks go through curl_multi_do, and hence are called with
> s->mutex held. Note that with comments, and make curl_read_cb drop the
> lock before invoking the callback.
>
> Likewise for curl_find_buf, where the callback can be invoked by the
> caller.
>
> Cc: address@hidden
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/curl.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-stable] [PATCH v2 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 1/7] curl: strengthen assertion in curl_clean_state, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 2/7] curl: never invoke callbacks with s->mutex held, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 4/7] curl: split curl_find_state/curl_init_state, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 3/7] curl: avoid recursive locking of BDRVCURLState mutex, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 7/7] curl: do not do aio_poll when waiting for a free CURLState, Paolo Bonzini, 2017/05/10