|
From: | Peter Lieven |
Subject: | Re: [Qemu-stable] [PATCH] qga: ignore EBUSY when freezing a filesystem |
Date: | Fri, 3 Feb 2017 09:20:06 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: > > On 31/01/2017 07:36, Peter Lieven wrote: >> the current implementation fails if we try to freeze an >> already frozen filesystem. This can happen if a filesystem >> is mounted more than once (e.g. with a bind mount). >> >> Suggested-by: Christian Theune <address@hidden> >> Cc: address@hidden >> Signed-off-by: Peter Lieven <address@hidden> > What happens when you thaw? > > Paolo If you try to THAW an unfrozen FS you get EINVAL. The current code thaws until an error is returned. So it should work as is. If you feel uncomfortable with the EBUSY approach. The other idea would be to track all devices which have been successfully frozen and skip consecutive tries to freeze them. Peter
[Prev in Thread] | Current Thread | [Next in Thread] |