Re: [Qemu-stable] [Qemu-devel] [PATCH] char: fix missing return in error path for chardev TLS init

[Eric Blake]

On 09/30/2016 10:02 AM, Daniel P. Berrange wrote:
> If the qio_channel_tls_new_(server|client) methods fail,
> we disconnect the client. Unfortunately a missing return
> means we then go on to try and run the TLS handshake on
> a NULL I/O channel. This gives predictably segfaulty
> results.
> 
> The main way to trigger this is to request a bogus TLS
> priority string for the TLS credentials. e.g.
> 
>   -object tls-creds-x509,id=tls0,priority=wibble,...
> 
> Most other ways appear impossible to trigger except
> perhaps if OOM conditions cause gnutls initialization
> to fail.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  qemu-char.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature