Re: [Qemu-stable] [PATCH v2 1/2] virtio: Add function to check whether backend supports VIRTIO_1

[Cornelia Huck]

On Fri,  9 Sep 2016 15:10:06 +0200
Maxime Coquelin <address@hidden> wrote:

> This patch adds virtio_test_backend_virtio_1() function to
> check whether backend supports VIRTIO_F_VERSION_1 before the
> negociation takes place.

s/negociation/negotiation/

> 
> Cc: Cornelia Huck <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: address@hidden
> Signed-off-by: Maxime Coquelin <address@hidden>
> ---
>  hw/virtio/virtio.c         | 13 +++++++++++++
>  include/hw/virtio/virtio.h |  1 +
>  2 files changed, 14 insertions(+)
> 
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index 74c085c..8b30b69 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -1481,6 +1481,19 @@ void virtio_vmstate_save(QEMUFile *f, void *opaque, 
> size_t size)
>      virtio_save(VIRTIO_DEVICE(opaque), f);
>  }
> 
> +bool virtio_test_backend_virtio_1(VirtIODevice *vdev, Error **errp)
> +{
> +    VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev);
> +    uint64_t feature;

As others had requested, I'd prefer setting this to 0 as well.

With that changed:

Reviewed-by: Cornelia Huck <address@hidden>