Re: [Qemu-stable] [Qemu-devel] [PATCH 1/3] migrate: Fix cpu-throttle-increment regression in HMP

[Marc-André Lureau]

On Fri, Sep 9, 2016 at 7:16 AM Eric Blake <address@hidden> wrote:

Commit 69ef1f3 accidentally broke migrate_set_parameter's ability
to set the cpu-throttle-increment to anything other than the
default, because it forgot to parse the user's string into an
integer.

CC: address@hidden
Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>

---
 hmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hmp.c b/hmp.c
index ad33b44..d6c6c01 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1286,6 +1286,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
                 break;
             case MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT:
                 has_cpu_throttle_increment = true;
+                use_int_value = true;
                 break;
             case MIGRATION_PARAMETER_TLS_CREDS:
                 has_tls_creds = true;
--
2.7.4

--

Marc-André Lureau