Re: [Qemu-stable] [Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup

[Eric Blake]

On 06/08/2016 04:42 AM, Daniel P. Berrange wrote:
> If VNC is chosen as the compile time default display backend,
> QEMU will print the host/port it listens on at startup.
> Previously this would look like
> 
>   VNC server running on '::1:5900'
> 
> but in 04d2529da27db512dcbd5e99d0e26d333f16efcc the ':' was
> accidentally replaced with a ';'. This the ':' back.
> 
> Reported-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  ui/vnc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/ui/vnc.c b/ui/vnc.c
> index c862fdc..75ae2a7 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3225,7 +3225,7 @@ char *vnc_display_local_addr(const char *id)
>          qapi_free_SocketAddress(addr);
>          return NULL;
>      }
> -    ret = g_strdup_printf("%s;%s", addr->u.inet.data->host,
> +    ret = g_strdup_printf("%s:%s", addr->u.inet.data->host,
>                            addr->u.inet.data->port);
>      qapi_free_SocketAddress(addr);
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature