Re: [Qemu-stable] [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

[Michael S. Tsirkin]

On Tue, Dec 29, 2015 at 07:17:46PM +0300, Roman Kagan wrote:
> On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote:
> > On Fri, 25 Dec 2015 18:04:08 +0300
> > Roman Kagan <address@hidden> wrote:
> > 
> > > Windows on UEFI systems is only capable of detecting the presence and
> > > the type of floppy drives via corresponding ACPI objects.
> > > 
> > > Those objects are added in the last patch of the series; the three
> > > preceding ones pave the way to it, by making the necessary data
> > > public and by moving the whole floppy drive controller description into
> > > runtime-generated SSDT.
> > > 
> > > Note that the series conflicts with Igor's patchset for dynamic DSDT, in
> > > particular, with "[PATCH 50/74] pc: acpi: move FDC0 device from DSDT
> > > to SSDT"; I haven't managed to avoid that while trying to meet
> > > maintainer's comments.
> > To remove conflicts and to make it more suitable for stable, I'd drop
> >  "2/4 i386/acpi: make floppy controller object dynamic"
> 
> Erm...  I thought I did what Michael requested:
> 
> On Thu, Dec 24, 2015 at 08:17:45AM +0200, Michael S. Tsirkin wrote:
> > Or rather, start series with a patch making FDC conditional,
> 
> So what do I need to do to get this thing merged?


Just split the test files away from patch itself.
Thanks!

> 
> > and split test blob out of
> >  "4/4 i386: populate floppy drive information in SSDT"
> > into a separate patch so one can see effects of applying 4/4
> > and then update blobs if resulting ASL diff is as expected.
> 
> This will break bisectability, won't it?
> 
> Roman.

No because diff in this test is just a warning.

-- 
MST