[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices |
|
Date: |
Tue, 29 Sep 2015 14:38:44 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 2/09/2015 10:05, Markus Armbruster wrote:
> > > 1. I made device-introspection-test run "info qom-tree", which has a
> > > lovely propensity to crash when a crappy device left dangling pointer
> > > behind. This led me to "cgthree", "cuda", "integrator_debug",
> > > "macio-oldworld", "macio-newworld", "pxa2xx-fir", "SUNW,tcx". They
> > > all create memory regions without owner in their instance_init()
> > > method.
> >
> > I guess these are all just "oops, we forgot to pass the Object* in
> > instead of NULL" bugs rather than more difficult fixes.
>
> I'm leaving the actual fixing to people with a better understanding of
> these devices, and ability to actually test them.
Gave it a shot...
Paolo