[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default VCPUs to node mapping |
Date: |
Fri, 20 Mar 2015 16:01:34 +0100 |
On Fri, 20 Mar 2015 11:52:46 -0300
Eduardo Habkost <address@hidden> wrote:
> On Fri, Mar 20, 2015 at 11:24:14AM +0100, Igor Mammedov wrote:
> > On Thu, 19 Mar 2015 17:09:20 +0000
> > Igor Mammedov <address@hidden> wrote:
> >
> > > Changes since v2:
> > > - fix spelling errors
> > > - split out PC hunks itno a separate patch
> > >
> > > Igor Mammedov (2):
> > > numa: introduce machine callback for VCPU to node mapping
> > > pc: fix default VCPU to NUMA node mapping
> > >
> > > hw/i386/pc.c | 9 +++++++++
> > > include/hw/boards.h | 5 +++++
> > > include/sysemu/numa.h | 3 ++-
> > > numa.c | 18 +++++++++++++-----
> > > vl.c | 2 +-
> > > 5 files changed, 30 insertions(+), 7 deletions(-)
> > >
> >
> > CCing stable which I've forgotten to do earlier
>
> Why stable? This can be easily worked around by explicitly setting the
> CPUs for each node. I see this as an usbility improvement, not a bug
> fix. And it breaks compatibility.
For me if guest hangs due to incorrect topology provided by QEMU, it's a bug.
I'm not sure about what compatibility it breaks though,
but I won't insist on making downstream (2.2 based) live easier
in this case since there is workaround.