[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-stable] [PATCH v3 03/13] block/vvfat: qcow driver may not be found
From: |
Max Reitz |
Subject: |
[Qemu-stable] [PATCH v3 03/13] block/vvfat: qcow driver may not be found |
Date: |
Tue, 2 Dec 2014 18:32:43 +0100 |
Although virtually impossible right now, bdrv_find_format("qcow") may
fail. The vvfat block driver should heed that case.
Cc: address@hidden
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
block/vvfat.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/vvfat.c b/block/vvfat.c
index cefe3a4..e34a789 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2917,6 +2917,12 @@ static int enable_write_target(BDRVVVFATState *s, Error
**errp)
}
bdrv_qcow = bdrv_find_format("qcow");
+ if (!bdrv_qcow) {
+ error_setg(errp, "Failed to locate qcow driver");
+ ret = -ENOENT;
+ goto err;
+ }
+
opts = qemu_opts_create(bdrv_qcow->create_opts, NULL, 0, &error_abort);
qemu_opt_set_number(opts, BLOCK_OPT_SIZE, s->sector_count * 512);
qemu_opt_set(opts, BLOCK_OPT_BACKING_FILE, "fat:");
--
1.9.3
- [Qemu-stable] [PATCH v3 00/13] block: Various Coverity-spotted fixes, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 03/13] block/vvfat: qcow driver may not be found,
Max Reitz <=
- [Qemu-stable] [PATCH v3 01/13] block: Make essential BlockDriver objects public, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 04/13] block/nfs: Add create_opts, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 02/13] block: Omit bdrv_find_format for essential drivers, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 06/13] qemu-img: Check create_opts before image creation, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 07/13] qemu-img: Check create_opts before image amendment, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 05/13] block: Check create_opts before image creation, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 09/13] iotests: Add test for unsupported image creation, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 08/13] iotests: Only kill NBD server if it runs, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 10/13] qcow2: Prevent numerical overflow, Max Reitz, 2014/12/02
- [Qemu-stable] [PATCH v3 12/13] qcow2: Respect bdrv_truncate() error, Max Reitz, 2014/12/02