Re: [Qemu-stable] [Qemu-devel] [PATCH v2 1/5] vmware-vga: CVE-2014-3689: turn off hw accel

[Don Koch]

On Wed, 15 Oct 2014 12:10:35 +0200
Gerd Hoffmann <address@hidden> wrote:

> Quick & easy stopgap for CVE-2014-3689:  We just compile out the
> hardware acceleration functions which lack sanity checks.  Thankfully
> we have capability bits for them (SVGA_CAP_RECT_COPY and
> SVGA_CAP_RECT_FILL), so guests should deal just fine, in theory.
> 
> Subsequent patches will add the missing checks and re-enable the
> hardware acceleration emulation.
> 
> Cc: address@hidden
> Signed-off-by: Gerd Hoffmann <address@hidden>

Reviewed-by: Don Koch <address@hidden>

> ---
>  hw/display/vmware_vga.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
> index 0c36c72..ec63290 100644
> --- a/hw/display/vmware_vga.c
> +++ b/hw/display/vmware_vga.c
> @@ -29,8 +29,10 @@
>  #include "hw/pci/pci.h"
>  
>  #undef VERBOSE
> +#if 0
>  #define HW_RECT_ACCEL
>  #define HW_FILL_ACCEL
> +#endif
>  #define HW_MOUSE_ACCEL
>  
>  #include "vga_int.h"
> -- 
> 1.8.3.1
> 
>