Re: [Qemu-stable] [Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

[Andreas Färber]

Am 28.04.2014 19:24, schrieb Richard Henderson:
> On 04/28/2014 10:20 AM, Stefan Weil wrote:
>> Commit 0f842f8a246f2b5b51a11c13f933bf7a90ae8e96 replaced GETPC_EXT() which
>> was derived from GETPC() by GETRA_EXT() without fixing cputlb.c. A later
>> patch replaced GETRA_EXT() by GETRA() in exec/softmmu_template.h which
>> is included in cputlb.c.
>>
>> The TCG interpreter failed because the values returned by GETRA() were no
>> longer explicitly set to 0. The redefinition of GETRA() introduced here
>> fixes this.
>>
>> In addition, GETPC_ADJ which is also used in exec/softmmu_template.h is
>> set to 0. Both changes reduce the compiled code size for cputlb.c by more
>> than 100 bytes, so the normal TCG without interpreter also profits from
>> the reduced code size and slightly faster code.
>>
>> Cc: address@hidden
>> Reported-by: Giovanni Mascellani <address@hidden>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
> 
> Reviewed-by: Richard Henderson <address@hidden>

No objections and not too familiar with that part of code myself -
suggest you take it through your tcg tree if no one else objects.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg