[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-stable] [PATCH 3/6] qga: vss-win32: Fix interference with snapshot
From: |
Michael Roth |
Subject: |
[Qemu-stable] [PATCH 3/6] qga: vss-win32: Fix interference with snapshot deletion by other VSS request |
Date: |
Sun, 23 Feb 2014 19:21:10 -0600 |
From: Tomoki Sekiyama <address@hidden>
When a VSS requester such as vshadow.exe or diskshadow.exe requests to
delete snapshots, qemu-ga VSS provider's DeleteSnapshots() is also called
and returns E_NOTIMPL, that makes the deletion fail.
To avoid this issue, return S_OK and set values that represent no snapshots
are deleted by qemu-ga VSS provider.
Signed-off-by: Tomoki Sekiyama <address@hidden>
Reviewed-by: Gal Hammer <address@hidden>
Reviewed-by: Yan Vugenfirer <address@hidden>
Cc: address@hidden
Signed-off-by: Michael Roth <address@hidden>
---
qga/vss-win32/provider.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp
index b233646..d5129f8 100644
--- a/qga/vss-win32/provider.cpp
+++ b/qga/vss-win32/provider.cpp
@@ -278,7 +278,9 @@ STDMETHODIMP CQGAVssProvider::DeleteSnapshots(
VSS_ID SourceObjectId, VSS_OBJECT_TYPE eSourceObjectType,
BOOL bForceDelete, LONG *plDeletedSnapshots, VSS_ID *pNondeletedSnapshotID)
{
- return E_NOTIMPL;
+ *plDeletedSnapshots = 0;
+ *pNondeletedSnapshotID = SourceObjectId;
+ return S_OK;
}
STDMETHODIMP CQGAVssProvider::BeginPrepareSnapshot(
--
1.7.9.5
- [Qemu-stable] [PULL 0/6] qemu-ga: various fixes, and serial support for w32, Michael Roth, 2014/02/23
- [Qemu-stable] [PATCH 1/6] qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent, Michael Roth, 2014/02/23
- [Qemu-stable] [PATCH 2/6] qga: vss-win32: Fix interference with snapshot creation by other VSS requesters, Michael Roth, 2014/02/23
- [Qemu-stable] [PATCH 3/6] qga: vss-win32: Fix interference with snapshot deletion by other VSS request,
Michael Roth <=
- [Qemu-stable] [PATCH 5/6] qga: Fix memory allocation pasto, Michael Roth, 2014/02/23
- [Qemu-stable] [PATCH 4/6] qga: Don't require 'time' argument in guest-set-time command, Michael Roth, 2014/02/23
- [Qemu-stable] [PATCH 6/6] qemu-ga: isa-serial support on Windows, Michael Roth, 2014/02/23
- Re: [Qemu-stable] [Qemu-devel] [PULL 0/6] qemu-ga: various fixes, and serial support for w32, Peter Maydell, 2014/02/25