Re: [Qemu-stable] [PATCH] KVM: Use return value for error print

[Tom Knych]

+1 

On Mon, Jan 27, 2014 at 6:18 AM, Alexander Graf <address@hidden> wrote:

Commit 94ccff13 introduced a more verbose failure message and retry
operations on KVM VM creation. However, it ended up using a variable
for its failure message that hasn't been initialized yet.

Fix it to use the value it meant to set.

Signed-off-by: Alexander Graf <address@hidden>
---
 kvm-all.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kvm-all.c b/kvm-all.c
index a3fb8de..3f78651 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -1427,7 +1427,7 @@ int kvm_init(void)
     } while (ret == -EINTR);

     if (ret < 0) {
-        fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -s->vmfd,
+        fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
                 strerror(-ret));

 #ifdef TARGET_S390X
--
1.8.1.4