Re: [Qemu-stable] [PATCH for-1.6] isapc: disable kvmvapic

[Doug Goldstein]

On Fri, Aug 30, 2013 at 7:14 PM, Cole Robinson <address@hidden> wrote:
> On 08/12/2013 06:02 PM, Paolo Bonzini wrote:
>> vapic requires the VAPIC ROM to be mapped into RAM.  This is not
>> possible without PAM hardware.  This fixes a segmentation fault
>> running with -M isapc.
>>
>> Cc: address@hidden
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>
>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>> index a19e172..3aa244a 100644
>> --- a/hw/i386/pc_piix.c
>> +++ b/hw/i386/pc_piix.c
>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>>      .init = pc_init_isa,
>>      .max_cpus = 1,
>>      .compat_props = (GlobalProperty[]) {
>> +        {
>> +            .driver   = "apic-common",
>> +            .property = "kvmvapic",
>> +            .value    = "off",
>> +        },
>>          { /* end of list */ }
>>      },
>>      DEFAULT_MACHINE_OPTIONS,
>>
>
> There's a Fedora bug about a related invocation crashing:
>
> ./x86_64-softmmu/qemu-system-x86_64 -machine accel=kvm -m 128 -vga std -boot d
> -cpu pentium -machine isapc
>
> https://bugzilla.redhat.com/show_bug.cgi?id=986790
>
> So I tried your patch on git master, but it gives:
>
> qemu-system-x86_64: Property '.kvmvapic' not found
>
> Changing the property name to 'vapic' fixes both issues for me.
>
> Thanks,
> Cole
>

Ping this patch. I had to make the same change as Cole for Gentoo as well.

-- 
Doug Goldstein