[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] ahci: Fix FLUSH command
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-stable] [PATCH] ahci: Fix FLUSH command |
Date: |
Mon, 15 Jul 2013 17:47:22 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jul 15, 2013 at 11:34:31AM +0200, Kevin Wolf wrote:
> AHCI couldn't cope with asynchronous commands that aren't doing DMA, it
> simply wouldn't complete them. Due to the bug fixed in commit f68ec837,
> FLUSH commands would seem to have completed immediately even if they
> were still running on the host. After the commit, they would simply hang
> and never unset the BSY bit, rendering AHCI unusable on any OS sending
> flushes.
>
> This patch adds another callback for the completion of asynchronous
> commands. This is what AHCI really wants to use for its command
> completion logic rather than an DMA completion callback.
>
> Cc: address@hidden
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> hw/ide/ahci.c | 8 +++++++-
> hw/ide/core.c | 9 +++++++++
> hw/ide/internal.h | 1 +
> 3 files changed, 17 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>