[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2] aio-posix: Fix return value of aio_poll()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-stable] [PATCH v2] aio-posix: Fix return value of aio_poll() |
Date: |
Thu, 17 Jan 2013 10:56:36 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 16, 2013 at 07:25:51PM +0100, Kevin Wolf wrote:
> aio_poll() must return true if any work is still pending, even if it
> didn't make progress, so that bdrv_drain_all() doesn't stop waiting too
> early. The possibility of stopping early occasionally lead to a failed
> assertion in bdrv_drain_all(), when some in-flight request was missed
> and the function didn't really drain all requests.
>
> In order to make that change, the return value as specified in the
> function comment must change for blocking = false; fortunately, the
> return value of blocking = false callers is only used in test cases, so
> this change shouldn't cause any trouble.
>
> Cc: address@hidden
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> aio-posix.c | 3 ++-
> aio-win32.c | 3 ++-
> include/block/aio.h | 6 ++----
> tests/test-aio.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
Changed "aio-posix" to "aio" in commit message.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan