Re: [PATCH v3 17/19] pc-bios/s390x: Enable multi-device boot loop

[Jared Rossi]

On 10/7/24 9:15 PM, jrossi@linux.ibm.com wrote:
> [snip...]
>
>       switch (vdev->senseid.cu_model) {
>       case VIRTIO_ID_NET:
>           puts("Network boot device detected");
> @@ -271,11 +275,9 @@ static void ipl_boot_device(void)
>           dasd_ipl(blk_schid, cutype);
>           break;
>       case CU_TYPE_VIRTIO:
> -        if (virtio_setup()) {
> -            return;    /* Only returns in case of errors */
> +        if (virtio_setup() == 0) {
> +            zipl_load();
>           }
> -        zipl_load();
> -        break;
>       default:
>           printf("Attempting to boot from unexpected device type 0x%X", cutype);
>       }
>
> [snip...]
A small mistake I found after posting is that the break is missing after
zipl_load(). This causes the "unexpected device type" message to print after
a failed virtio IPL, but it is fixed simply by not removing the break 
and will
be will be corrected in the next version.