qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 06/14] s390x: introduce s390_get_memory_limit()


From: David Hildenbrand
Subject: Re: [PATCH v1 06/14] s390x: introduce s390_get_memory_limit()
Date: Mon, 23 Sep 2024 11:20:41 +0200
User-agent: Mozilla Thunderbird



Looks good.

Looking at the patch again I'm wondering if using globals in qemu is still 
encouraged.
I know it's a common pattern today, but seeing efforts like the multiarch 
binary or Unicorn
I'm wondering if there is aspirations to do things more "cleanly", in general, 
for far out benefits?
I.e. memory_limit could be a machine property instead.

Yes, I'll rework that code to simply store it in the machine, moving that code out of cpu-sysemu.c int s390-virtio-ccw.c.

Same for patch #12, thanks!

--
Cheers,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]