[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/39] migration: replace assert(false) with g_assert_not_rea
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH 21/39] migration: replace assert(false) with g_assert_not_reached() |
Date: |
Tue, 10 Sep 2024 19:26:01 -0300 |
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> migration/dirtyrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 1d9db812990..a28c07327e8 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -228,7 +228,7 @@ static int time_unit_to_power(TimeUnit time_unit)
> case TIME_UNIT_MILLISECOND:
> return -3;
> default:
> - assert(false); /* unreachable */
> + g_assert_not_reached(); /* unreachable */
> return 0;
> }
> }
You could drop the comment that's now redundant.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- [PATCH 16/39] hw/hyperv: replace assert(false) with g_assert_not_reached(), (continued)
- [PATCH 21/39] migration: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
- [PATCH 22/39] target/i386/kvm: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
- [PATCH 19/39] hw/pci: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
- [PATCH 23/39] tests/qtest: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
- [PATCH 24/39] accel/tcg: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
- [PATCH 26/39] hw/acpi: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
- [PATCH 27/39] hw/gpio: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/10