Re: [PATCH v2 4/7] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

[Thomas Huth]

On 25/04/2024 05.12, Zhao Liu wrote:
> As error.h suggested, the best practice for callee is to return
> something to indicate success / failure.
>
> So make kvm_s390_get_host_cpu_model() return boolean and check the
> returned boolean in get_max_cpu_model() instead of accessing @err.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   target/s390x/cpu_models.c |  9 ++++-----
>   target/s390x/cpu_models.h |  2 +-
>   target/s390x/kvm/kvm.c    | 13 +++++++------
>   3 files changed, 12 insertions(+), 12 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>